sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zoltán Tóth <swank.vali...@gmail.com>
Subject Re: Review Request 62028: Remove Sqoop dependency on deprecated HBase APIs
Date Fri, 08 Sep 2017 14:14:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62028/#review184973
-----------------------------------------------------------



Hey Szabi,

Thanks for the contribution especially for good test coverage.

I added some comments, please check them and decide about them.

Cheers, Zoli


src/java/org/apache/sqoop/hbase/HBasePutProcessor.java
Lines 180 (patched)
<https://reviews.apache.org/r/62028/#comment261198>

    You can make it a one liner if you want to but it is a question of taste
    
    mutation != null && (mutation instanceof Put || mutation instanceof Delete)



src/java/org/apache/sqoop/hbase/HBasePutProcessor.java
Line 163 (original), 190 (patched)
<https://reviews.apache.org/r/62028/#comment261200>

    Method throws IOException but we catch it inside the method. Either remove the throws
from method head or throw the exception to the caller.



src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java
Lines 97 (patched)
<https://reviews.apache.org/r/62028/#comment261201>

    Exception is too general. Please use specific exception here.



src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java
Lines 98 (patched)
<https://reviews.apache.org/r/62028/#comment261202>

    Don't you want to log if it cannot get HBaseTable? Maybe it will be logged on higher level



src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java
Lines 130 (patched)
<https://reviews.apache.org/r/62028/#comment261203>

    Can you change general exception into specified ones?



src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java
Lines 149 (patched)
<https://reviews.apache.org/r/62028/#comment261204>

    If the error message is not neccessary then you can leave the exception to be thrown to
to the caller method.


- Zoltán Tóth


On Sept. 1, 2017, 9:30 a.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62028/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2017, 9:30 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3232
>     https://issues.apache.org/jira/browse/SQOOP-3232
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Sqoop currently depends on pre HBase 1.0 APIs that have been deprecated and will be removed
in the HBase 2.0 release.
> The task is to remove the dependency on these old APIs to make sure that the upgrade
to a newer HBase version will be easier in the future.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/hbase/HBasePutProcessor.java 032fd38ad0ff13372ae70be47e38db8c4ba8ef8f

>   src/java/org/apache/sqoop/mapreduce/HBaseBulkImportJob.java 2bbfffe03844517da9d0d7c94380a8fb57c5eb29

>   src/java/org/apache/sqoop/mapreduce/HBaseImportJob.java 523d0a7ede70e16b4e80f8349f08c67eba2e4d01

>   src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 8b29b5fdb00e223a4f2af14b8a9cbfd9ba9d7d83

>   src/test/org/apache/sqoop/hbase/TestHBasePutProcessor.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62028/diff/1/
> 
> 
> Testing
> -------
> 
> Added a new test case for the small refactoring I did.
> Ran all unit and third party tests successfully.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message