sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zoltán Tóth <swank.vali...@gmail.com>
Subject Re: Review Request 62057: SQOOP-3014 Sqoop with HCatalog import loose precision for large numbers that does not fit into double
Date Tue, 12 Sep 2017 12:19:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62057/
-----------------------------------------------------------

(Updated Sept. 12, 2017, 12:19 p.m.)


Review request for Sqoop, Boglarka Egyed and Anna Szonyi.


Changes
-------

Change updated based on review


Bugs: SQOOP-3014
    https://issues.apache.org/jira/browse/SQOOP-3014


Repository: sqoop-trunk


Description
-------

HCatalog rounded BigDecimals but that should not happen. Now Sqoop HCatalog doesn't change
BigDecimals


Diffs (updated)
-----

  src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java aba2458e 
  src/test/org/apache/sqoop/hcat/HCatalogImportTest.java d784a205 
  src/test/org/apache/sqoop/mapreduce/hcat/TestSqoopHCatImportHelper.java PRE-CREATION 


Diff: https://reviews.apache.org/r/62057/diff/3/

Changes: https://reviews.apache.org/r/62057/diff/2-3/


Testing
-------

I ran unit tests and integration tests as well. New test cases were added to test the change


Thanks,

Zoltán Tóth


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message