sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Ang <alexan...@gmail.com>
Subject Re: Review Request 59710: SQOOP-3190: Remove dependency on PSQL for postgres direct import
Date Thu, 28 Sep 2017 16:48:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59710/
-----------------------------------------------------------

(Updated Sept. 28, 2017, 4:48 p.m.)


Review request for Sqoop and Szabolcs Vasas.


Changes
-------

Fixed whitespace and encoding issues.


Bugs: SQOOP-3190
    https://issues.apache.org/jira/browse/SQOOP-3190


Repository: sqoop-trunk


Description
-------

Current Postgres direct import requires the installation of the psql utility on all hadoop
nodes. However, due to system constraints, this may not always be possible. 
It should be noted that Postgres provides a Java API which can execute the same copy command
as the psql utility. As such, it would be more ideal to remove the psql utility dependency
and switch to the Postgres Java API.


Diffs (updated)
-----

  src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java 63b0704 


Diff: https://reviews.apache.org/r/59710/diff/3/

Changes: https://reviews.apache.org/r/59710/diff/2-3/


Testing
-------

Tested with PostgresqlImportTest and passed all tests.


Thanks,

Alex Ang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message