sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <b...@apache.org>
Subject Re: Review Request 62574: Document how to run third party tests manually with databases running in docker
Date Tue, 03 Oct 2017 15:22:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62574/#review186953
-----------------------------------------------------------


Ship it!




Hi Szabolcs,

Thank you very much for making the 3rd party test execution easier!

I think this dockerization effort was a huge improvement for the Sqoop devs - it also makes
much easier to review patches in the future.

Thanks,
Bogi

- Boglarka Egyed


On Oct. 3, 2017, 1:20 p.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62574/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2017, 1:20 p.m.)
> 
> 
> Review request for Sqoop and Zach Berkowitz.
> 
> 
> Bugs: SQOOP-3229
>     https://issues.apache.org/jira/browse/SQOOP-3229
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Documentation is added to COMPILING.txt, docker-compose file and helper scripts are added.
> 
> 
> Diffs
> -----
> 
>   COMPILING.txt eb69b220ecdaedd4d279259aba92df143482145a 
>   scripts/thirdpartytest/docker-compose/db2scripts/db2entrypoint.sh PRE-CREATION 
>   scripts/thirdpartytest/docker-compose/oraclescripts/healthcheck.sh PRE-CREATION 
>   scripts/thirdpartytest/docker-compose/oraclescripts/startup/oracleusersetup.sql PRE-CREATION

>   scripts/thirdpartytest/docker-compose/sqoop-thirdpartytest-db-services.yml PRE-CREATION

>   scripts/thirdpartytest/start-thirdpartytest-db-containers.sh PRE-CREATION 
>   scripts/thirdpartytest/stop-thirdpartytest-db-containers.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62574/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message