sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Teoh <chris.t...@gmail.com>
Subject Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk
Date Thu, 19 Oct 2017 10:25:25 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 19, 2017, 10:25 a.m.)

Review request for Sqoop.


Removed reformatting.

Bugs: SQOOP-3225

Repository: sqoop-trunk


There were some cases where the FTP listing parser was not used for mainframe datasets, only
the default was used. This caused some datasets to not be seen by Sqoop as the default parser
couldn't find them. This patch addresses this behaviour where it is used to parse FTP listings
for sequential and gdg datasets on disk and tape, only partitioned datasets are excluded as
their FTP listing looks very different and is handled by the default FTP listing parser.

Diffs (updated)

  src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java f61b9838 
  src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java d87c75df 

Diff: https://reviews.apache.org/r/62653/diff/6/

Changes: https://reviews.apache.org/r/62653/diff/5-6/


Unit testing.
Functional testing on a real mainframe with a previous combined patch.


Chris Teoh

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message