sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <b...@apache.org>
Subject Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test running related info in COMPILING.txt
Date Thu, 07 Dec 2017 16:46:04 GMT


> On Dec. 7, 2017, 4:11 p.m., Fero Szabo wrote:
> > COMPILING.txt
> > Lines 105-106 (patched)
> > <https://reviews.apache.org/r/64251/diff/1/?file=1905879#file1905879line105>
> >
> >     I believe there is a typo here:
> >     qoop.test.oracle.xy >> sqoop.test.oracle.xy
> >     
> >     Also, a question: 
> >     Why is sqoop.test.oracle.databasename not specified? is it not needed or supported?

Thanks for catching the typo!

There is no sqoop.test.oracle.databasename property currently in Sqoop, the name of the database
should be added to the end of the connect string for Oracle.


- Boglarka


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64251/#review193127
-----------------------------------------------------------


On Dec. 1, 2017, 5:30 p.m., Boglarka Egyed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64251/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2017, 5:30 p.m.)
> 
> 
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3266
>     https://issues.apache.org/jira/browse/SQOOP-3266
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> MSSQL tests have been added to 3rd part test suite in SQOOP-3174, COMPILING.txt should
be updated accordingly. Also, 3rd party test execution on native database servers could be
more verbose.
> 
> 
> Diffs
> -----
> 
>   COMPILING.txt f531dd49a77d86b747478b4b8aad1a62d63515af 
> 
> 
> Diff: https://reviews.apache.org/r/64251/diff/1/
> 
> 
> Testing
> -------
> 
> Only text change.
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message