sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fero Szabo via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 64371: SQOOP-3233: SqoopHCatImportHelper.convertNumberTypes check for Varchar instead of Char
Date Thu, 07 Dec 2017 17:23:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64371/
-----------------------------------------------------------

(Updated Dec. 7, 2017, 5:23 p.m.)


Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.


Changes
-------

Implemented Szabi's recommendations. Also renamed the bd variable to bigDecimal for clarity.


Bugs: SQOOP-3233
    https://issues.apache.org/jira/browse/SQOOP-3233


Repository: sqoop-trunk


Description
-------

- Corrected the type from VARCHAR to CHAR in SqoopHCatImportHelper.convertNumberTypes, that
the ticket description mentions.
- Found another bug in the convertNumberTypes function: missing parentheses in the if clause
that checks whether the type of val is BigDecimal. Corrected it.
- Slight refactoring: extracted the BigDecimal and Number related conversion code into two
different methods, for better readability.


Diffs (updated)
-----

  src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java 1c1ed1e5 
  src/test/org/apache/sqoop/hcat/HCatalogImportTest.java 4686493c 


Diff: https://reviews.apache.org/r/64371/diff/3/

Changes: https://reviews.apache.org/r/64371/diff/2-3/


Testing
-------

Ran unit tests (ant clean test), and third party tests as well successfully.


Thanks,

Fero Szabo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message