sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From szvasas <...@git.apache.org>
Subject [GitHub] sqoop pull request #41: Sqoop-3224: Binary ftp transfer mode
Date Fri, 22 Dec 2017 14:46:35 GMT
Github user szvasas commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/41#discussion_r158502914
  
    --- Diff: src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java
---
    @@ -0,0 +1,128 @@
    +/**
    --- End diff --
    
    I am still not sure we will need this new class.
    I understand that when a SqoopRecord is generated runtime it will always have a text field
and not binary but that might be solved by changing org.apache.sqoop.manager.MainframeManager#getColumnTypes
    
    My guess is that if we changed that to return column type based on the transfer mode or
file type in the SqoopOptions object we could just use the generated class.


---

Mime
View raw message