sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szabolcs Vasas <vasas.szabo...@gmail.com>
Subject Re: Review Request 65020: HBase test cases should start mini DFS cluster as well
Date Mon, 08 Jan 2018 17:01:56 GMT


> On Jan. 8, 2018, 3:22 p.m., Fero Szabo wrote:
> > src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java
> > Lines 81 (patched)
> > <https://reviews.apache.org/r/65020/diff/1/?file=1935495#file1935495line83>
> >
> >     Just out of curiosity, what does port "0" mean / do here? Is this a setting
that is practically never used, but needed?

This configuration parameter will be used in org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager#DatanodeManager,
0 basically means that the system will pick up an ephemeral port for creating the socket (see:
org.apache.hadoop.net.NetUtils#createSocketAddrForHost)


- Szabolcs


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65020/#review194949
-----------------------------------------------------------


On Jan. 8, 2018, 3:15 p.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65020/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2018, 3:15 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3275
>     https://issues.apache.org/jira/browse/SQOOP-3275
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> HBaseTestCase.setUp() now calls org.apache.hadoop.hbase.HBaseTestingUtility#startMiniCluster()
method to start up HBase, Zookeeper and HDFS mini clusters.
> Since HDFS mini cluster is started we need to set extra Kerberos-related properties in
the setupKerberos() method.
> 
> 
> Diffs
> -----
> 
>   ivy.xml 86de94f6440604ccbbd5192599a5fadb8796f7a9 
>   src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java cf42d317a339360e0242dc030dc2d732896c9b32

> 
> 
> Diff: https://reviews.apache.org/r/65020/diff/1/
> 
> 
> Testing
> -------
> 
> Executed unit and third party tests.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message