sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-3241) ImportAllTablesTool uses the same SqoopOptions object for every table import
Date Fri, 05 Jan 2018 14:32:00 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313200#comment-16313200
] 

Hudson commented on SQOOP-3241:
-------------------------------

SUCCESS: Integrated in Jenkins build Sqoop-hadoop200 #1142 (See [https://builds.apache.org/job/Sqoop-hadoop200/1142/])
SQOOP-3241: ImportAllTablesTool uses the same SqoopOptions object for (vasas: [https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=7ef6a8013a99738e38a41b20f1f0edccc927a9b8])
* (edit) src/java/org/apache/sqoop/tool/ImportAllTablesTool.java
* (edit) src/java/org/apache/sqoop/SqoopOptions.java
* (edit) src/test/org/apache/sqoop/TestSqoopOptions.java
* (edit) ivy.xml
* (edit) ivy/libraries.properties


> ImportAllTablesTool uses the same SqoopOptions object for every table import
> ----------------------------------------------------------------------------
>
>                 Key: SQOOP-3241
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3241
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.6
>            Reporter: Szabolcs Vasas
>            Assignee: Ferenc Szabo
>         Attachments: SQOOP-3241.patch, SQOOP-3241.patch
>
>
> ImportAllTablesTool queries the list of tables from the database and invokes ImportTool#importTable
method for each table.
> The problem is that it passes the same SqoopOptions object in every invocation and since
SqoopOptions is not immutable this can lead to issues.
> For example in case of Parquet imports the CodeGenTool#generateORM method modifies the
className field of the SqoopOptions object which is then remains the same for all the subsequent
table imports and can cause job failures.
> One solution could be to create a new SqoopOptions object with the same field values
for every ImportTool#importTable invocation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message