sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-3283) MySQL thirdparty tests hang if there's no USER environment variable
Date Wed, 14 Feb 2018 19:04:00 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364622#comment-16364622
] 

Hudson commented on SQOOP-3283:
-------------------------------

SUCCESS: Integrated in Jenkins build Sqoop-hadoop200 #1148 (See [https://builds.apache.org/job/Sqoop-hadoop200/1148/])
SQOOP-3283: Fixing MySQL 3rd party test hanging issue by getting (maugli: [https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3153c3610da7e5db388bfb14f3681d308e9e89c6])
* (edit) src/test/org/apache/sqoop/manager/mysql/MySQLTestUtils.java


> MySQL thirdparty tests hang if there's no USER environment variable
> -------------------------------------------------------------------
>
>                 Key: SQOOP-3283
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3283
>             Project: Sqoop
>          Issue Type: Bug
>          Components: connectors/mysql, test
>    Affects Versions: 1.4.7
>            Reporter: Daniel Voros
>            Assignee: Daniel Voros
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: SQOOP-3283.1.patch, SQOOP-3283.2.patch
>
>
> {{org.apache.sqoop.manager.mysql.MySQLTestUtils#getCurrentUser()}} executes {{whoami}}
in a subprocess if there's no USER environment variable (happened to me while running tests
from Docker). However, it waits for the Process variable to become null, that never happens:
> {code:java}
> // wait for whoami to exit.
> while (p != null) {
>   try {
>     int ret = p.waitFor();
>     if (0 != ret) {
>       LOG.error("whoami exited with error status " + ret);
>       // suppress original return value from this method.
>       return null;
>     }
>   } catch (InterruptedException ie) {
>     continue; // loop around.
>   }
> }
> {code}
> We could get rid of the while loop since {{Process#waitFor()}} blocks while it completes.
> Note, that it's easy to workaround the issue by setting the USER environment variable
when running the tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message