sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daniel voros <daniel.vo...@gmail.com>
Subject Review Request 65884: SqoopJobDataPublisher is invoked before Hive/HCat imports succeed
Date Fri, 02 Mar 2018 15:39:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65884/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-3291
    https://issues.apache.org/jira/browse/SQOOP-3291


Repository: sqoop-trunk


Description
-------

Job data is published to listeners (defined via sqoop.job.data.publish.class) in case of Hive
and HCat imports. Currently this happens before the Hive import completes, so it gets reported
even if Hive import fails.


Diffs
-----

  src/java/org/apache/sqoop/hive/HiveImport.java c272911 
  src/java/org/apache/sqoop/mapreduce/ExportJobBase.java 6529bd2 
  src/java/org/apache/sqoop/mapreduce/ImportJobBase.java fb5d054 
  src/java/org/apache/sqoop/mapreduce/PublishJobData.java fc18188 
  src/java/org/apache/sqoop/tool/ImportTool.java e992005 
  src/test/org/apache/sqoop/TestSqoopJobDataPublisher.java b3579ac 
  src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java a5f85a0 


Diff: https://reviews.apache.org/r/65884/diff/1/


Testing
-------

- created unit test
 - tested on a cluster with Atlas SqoopHook in place


Thanks,

daniel voros


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message