sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anna Szonyi via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build for Sqoop to make it more developer friendly / open
Date Fri, 23 Mar 2018 10:28:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/
-----------------------------------------------------------

(Updated March 23, 2018, 10:28 a.m.)


Review request for Sqoop.


Changes
-------

Apologies for the barrage of changes - fixed messed up diff


Bugs: Sqoop-3052
    https://issues.apache.org/jira/browse/Sqoop-3052


Repository: sqoop-trunk


Description
-------

SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open


Diffs (updated)
-----

  .gitignore 68cbe28 
  COMPILING.txt 3b82250 
  build.gradle PRE-CREATION 
  buildSrc/customUnixStartScript.txt PRE-CREATION 
  buildSrc/customWindowsStartScript.txt PRE-CREATION 
  buildSrc/sqoop-package.gradle PRE-CREATION 
  buildSrc/sqoop-version-gen.gradle PRE-CREATION 
  config/checkstyle/checkstyle-java-header.txt PRE-CREATION 
  config/checkstyle/checkstyle-noframes.xsl PRE-CREATION 
  config/checkstyle/checkstyle.xml PRE-CREATION 
  gradle.properties PRE-CREATION 
  gradle/wrapper/gradle-wrapper.jar PRE-CREATION 
  gradle/wrapper/gradle-wrapper.properties PRE-CREATION 
  gradlew PRE-CREATION 
  gradlew.bat PRE-CREATION 
  settings.gradle PRE-CREATION 


Diff: https://reviews.apache.org/r/66067/diff/6/

Changes: https://reviews.apache.org/r/66067/diff/5-6/


Testing
-------

ran all new tasks, except for internal maven publishing

Notes:
- To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to
current tasks/artifacts.
- Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all
test results into a single report.
- Generated pom.xml now has correct dependencies/versions
- Script generation is currently hardcoded and not based on sqoop help, as previously - though
added the possiblity of hooking it in later


Thanks,

Anna Szonyi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message