sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From christeoh <...@git.apache.org>
Subject [GitHub] sqoop pull request #44: [SQOOP-3224] Binary transfer mode
Date Fri, 23 Mar 2018 12:18:47 GMT
Github user christeoh commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/44#discussion_r176717474
  
    --- Diff: src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java ---
    @@ -207,8 +208,18 @@ public static FTPClient getFTPConnection(Configuration conf)
             throw new IOException("Could not login to server " + server
                 + ":" + ftp.getReplyString());
           }
    -      // set ASCII transfer mode
    -      ftp.setFileType(FTP.ASCII_FILE_TYPE);
    +      // set transfer mode
    +      String transferMode = conf.get(MainframeConfiguration.MAINFRAME_FTP_TRANSFER_MODE);
    --- End diff --
    
    I'm not sure how you would refactor it. I can give it a try and see if it is what you're
looking for.


---

Mime
View raw message