sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <b...@apache.org>
Subject Re: Review Request 66246: Fix warnings during Sqoop compilation
Date Sun, 25 Mar 2018 14:31:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66246/#review199932
-----------------------------------------------------------


Ship it!




Tested both with ant and gradle.

- Boglarka Egyed


On March 23, 2018, 1:30 p.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66246/
> -----------------------------------------------------------
> 
> (Updated March 23, 2018, 1:30 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3303
>     https://issues.apache.org/jira/browse/SQOOP-3303
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Ant prints the following warning during every Sqoop compilation:
> 
> /Users/szabolcsvasas/Documents/workspace/sqoop/sqoop-vasas-gradle/sqoop/src/test/org/apache/sqoop/TestAvroExport.java:477:
warning: non-varargs call of varargs method with inexact argument type for last parameter;
> 
>     createAvroFile(0, TOTAL_RECORDS, null);
> 
>                                      ^
> 
>   cast to ColumnGenerator for a varargs call
> 
>   cast to ColumnGenerator[] for a non-varargs call and to suppress this warning
> 
> /Users/szabolcsvasas/Documents/workspace/sqoop/sqoop-vasas-gradle/sqoop/src/test/org/apache/sqoop/TestAvroExport.java:492:
warning: non-varargs call of varargs method with inexact argument type for last parameter;
> 
>     createAvroFile(0, TOTAL_RECORDS, null);
> 
>                                      ^
> 
>   cast to ColumnGenerator for a varargs call
> 
>   cast to ColumnGenerator[] for a non-varargs call and to suppress this warning
> 
> /Users/szabolcsvasas/Documents/workspace/sqoop/sqoop-vasas-gradle/sqoop/src/test/org/apache/sqoop/TestParquetExport.java:422:
warning: non-varargs call of varargs method with inexact argument type for last parameter;
> 
>     createParquetFile(0, TOTAL_RECORDS, null);
> 
>                                         ^
> 
>   cast to ColumnGenerator for a varargs call
> 
>   cast to ColumnGenerator[] for a non-varargs call and to suppress this warning
> 
> /Users/szabolcsvasas/Documents/workspace/sqoop/sqoop-vasas-gradle/sqoop/src/test/org/apache/sqoop/TestParquetExport.java:435:
warning: non-varargs call of varargs method with inexact argument type for last parameter;
> 
>     createParquetFile(0, TOTAL_RECORDS, null);
> 
>                                         ^
> 
>   cast to ColumnGenerator for a varargs call
> 
>   cast to ColumnGenerator[] for a non-varargs call and to suppress this warning
> It is kind of annoying and would be very easy to fix.
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/TestAvroExport.java d1f10549f8c13c1433e8cb624d1bd97bb998fdf6

>   src/test/org/apache/sqoop/TestParquetExport.java fdaa5d810dc3562723bd397b72206ed36c889d36

> 
> 
> Diff: https://reviews.apache.org/r/66246/diff/1/
> 
> 
> Testing
> -------
> 
> ant test
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message