sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szabolcs Vasas <vasas.szabo...@gmail.com>
Subject Re: Review Request 66282: Mock ConnManager field in TestTableDefWriter
Date Mon, 26 Mar 2018 14:02:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66282/
-----------------------------------------------------------

(Updated March 26, 2018, 2:02 p.m.)


Review request for Sqoop.


Bugs: SQOOP-3308
    https://issues.apache.org/jira/browse/SQOOP-3308


Repository: sqoop-trunk


Description
-------

This patch removes the externalColTypes field from TableDefWriter since it was only used for
testing purposes.
TestTableDefWriter is fixed to mock the ConnManager object provided to the TableDefWriter
constructor and a minor refactoring is done on the class.


Diffs (updated)
-----

  src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 
  src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 


Diff: https://reviews.apache.org/r/66282/diff/3/

Changes: https://reviews.apache.org/r/66282/diff/2-3/


Testing
-------

ant clean test


Thanks,

Szabolcs Vasas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message