sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daniel voros <daniel.vo...@gmail.com>
Subject Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build for Sqoop to make it more developer friendly / open
Date Wed, 28 Mar 2018 11:02:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review200102
-----------------------------------------------------------



Hey Anna,

I've experimented with running the gradle build in a clean dockerized environment and found
some minor issues:
 1) All dependencies are downloaded from jcenter, despite having central repository defined
in build.gradle. This might be a result of my current setup, could you please confirm?
 2) Deprecation warnings for '<<' task doLast syntax ("Deprecation warning: The Task.leftShift(Closure)
method has been deprecated...")
 3) SqoopVersion.java generation happens during task definition and not in action (missing
doLast?).
 4) `relnotes` task fails if version is SNAPSHOT with: "A problem occurred starting process
'command 'cd''".
 5) The `release` task prints the path of tar and rat report but they're incorrect. (I've
specified version on the command line with "-Pversion=1.5.0")
 6) `ant releaseaudit` now lists gradle files as errors

I've corrected 2,3,4,5,6 in this commit: https://github.com/dvoros/sqoop/commit/47e361829b1004bdedd6f5c223332e3fb8b85696

What's the reasoning behind using Gradle 3.5.1? Shouldn't we use 4.x? (I've successfully executed
a simple build with 4.6)

Regards,
Daniel

- daniel voros


On March 23, 2018, 10:28 a.m., Anna Szonyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
> 
> (Updated March 23, 2018, 10:28 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: Sqoop-3052
>     https://issues.apache.org/jira/browse/Sqoop-3052
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly
/ open
> 
> 
> Diffs
> -----
> 
>   .gitignore 68cbe28 
>   COMPILING.txt 3b82250 
>   build.gradle PRE-CREATION 
>   buildSrc/customUnixStartScript.txt PRE-CREATION 
>   buildSrc/customWindowsStartScript.txt PRE-CREATION 
>   buildSrc/sqoop-package.gradle PRE-CREATION 
>   buildSrc/sqoop-version-gen.gradle PRE-CREATION 
>   config/checkstyle/checkstyle-java-header.txt PRE-CREATION 
>   config/checkstyle/checkstyle-noframes.xsl PRE-CREATION 
>   config/checkstyle/checkstyle.xml PRE-CREATION 
>   gradle.properties PRE-CREATION 
>   gradle/wrapper/gradle-wrapper.jar PRE-CREATION 
>   gradle/wrapper/gradle-wrapper.properties PRE-CREATION 
>   gradlew PRE-CREATION 
>   gradlew.bat PRE-CREATION 
>   settings.gradle PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66067/diff/6/
> 
> 
> Testing
> -------
> 
> ran all new tasks, except for internal maven publishing
> 
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them
to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine
all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as previously
- though added the possiblity of hooking it in later
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message