sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-3224) Mainframe FTP transfer should have an option to use binary mode for transfer
Date Mon, 19 Mar 2018 15:59:00 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405021#comment-16405021
] 

ASF GitHub Bot commented on SQOOP-3224:
---------------------------------------

Github user fszabo2 commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/44#discussion_r175484508
  
    --- Diff: src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java ---
    @@ -362,4 +363,29 @@ public void testPartitionedDatasetsShouldReturnAllFiles() {
           Assert.fail(ioeString);
         }
       }
    +  @Test
    +  public void testBinaryTransferMode() throws IOException {
    +    final String EXPECTED_RESPONSE = "200 Representation type is Image";
    +    final int EXPECTED_RESPONSE_CODE = 200;
    +    when(mockFTPClient.login("user", "pssword")).thenReturn(true);
    --- End diff --
    
    is the typo "pssword" intentional? Though won't cause any trouble I guess...


> Mainframe FTP transfer should have an option to use binary mode for transfer
> ----------------------------------------------------------------------------
>
>                 Key: SQOOP-3224
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3224
>             Project: Sqoop
>          Issue Type: Improvement
>            Reporter: Chris Teoh
>            Assignee: Chris Teoh
>            Priority: Minor
>
> Currently the mainframe FTP module is hard coded to use ascii transfer mode. Propose
a mainframe module flag to be able to change modes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message