sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szabolcs Vasas (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SQOOP-3308) Mock ConnManager field in TestTableDefWriter
Date Tue, 27 Mar 2018 12:00:00 GMT

     [ https://issues.apache.org/jira/browse/SQOOP-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Szabolcs Vasas updated SQOOP-3308:
----------------------------------
    Attachment: SQOOP-3308.patch

> Mock ConnManager field in TestTableDefWriter
> --------------------------------------------
>
>                 Key: SQOOP-3308
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3308
>             Project: Sqoop
>          Issue Type: Sub-task
>    Affects Versions: 1.5.0
>            Reporter: Szabolcs Vasas
>            Assignee: Szabolcs Vasas
>            Priority: Major
>         Attachments: SQOOP-3308.patch, SQOOP-3308.patch, SQOOP-3308.patch, SQOOP-3308.patch
>
>
> TableDefWriter has a dependency on ConnManager to retrieve the names and the types of
the table. It also introduces a field called _externalColTypes_ for testing purposes and TestTableDefWriter
uses this field to inject the test table column names and types instead of mocking the ConnManager
field.
> This setup makes it harder to add test cases to TestTableDefWriter and not a good practice
so it should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message