sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-3308) Mock ConnManager field in TestTableDefWriter
Date Thu, 29 Mar 2018 14:33:00 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419089#comment-16419089
] 

Hudson commented on SQOOP-3308:
-------------------------------

SUCCESS: Integrated in Jenkins build Sqoop-hadoop200 #1157 (See [https://builds.apache.org/job/Sqoop-hadoop200/1157/])
SQOOP-3308: Mock ConnManager field in TestTableDefWriter (bogi: [https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d2c40366a7458b0f4804a382403bb40ac72fbb4f])
* (edit) src/java/org/apache/sqoop/hive/TableDefWriter.java
* (edit) src/test/org/apache/sqoop/hive/TestTableDefWriter.java


> Mock ConnManager field in TestTableDefWriter
> --------------------------------------------
>
>                 Key: SQOOP-3308
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3308
>             Project: Sqoop
>          Issue Type: Sub-task
>    Affects Versions: 1.5.0
>            Reporter: Szabolcs Vasas
>            Assignee: Szabolcs Vasas
>            Priority: Major
>         Attachments: SQOOP-3308.patch, SQOOP-3308.patch, SQOOP-3308.patch, SQOOP-3308.patch
>
>
> TableDefWriter has a dependency on ConnManager to retrieve the names and the types of
the table. It also introduces a field called _externalColTypes_ for testing purposes and TestTableDefWriter
uses this field to inject the test table column names and types instead of mocking the ConnManager
field.
> This setup makes it harder to add test cases to TestTableDefWriter and not a good practice
so it should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message