sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szabolcs Vasas <vasas.szabo...@gmail.com>
Subject Re: Review Request 66221: SQOOP-3301 Document SQOOP-3216 - metastore related change
Date Fri, 06 Apr 2018 08:01:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66221/#review200629
-----------------------------------------------------------




src/docs/user/metastore-purpose.txt
Lines 20 (patched)
<https://reviews.apache.org/r/66221/#comment281395>

    do we need this extra new line here?



src/docs/user/metastore-purpose.txt
Line 26 (original), 30 (patched)
<https://reviews.apache.org/r/66221/#comment281396>

    I think we should explicitly state that MySQL, MSSQL,  Hsqldb, PostgreSQL, Oracle and
DB2 are supported since we only test these. Other RDBMSs might work but we should not confuse
the users.



src/docs/user/saved-jobs.txt
Lines 160 (patched)
<https://reviews.apache.org/r/66221/#comment281393>

    typo: paramter



src/docs/user/saved-jobs.txt
Lines 161 (patched)
<https://reviews.apache.org/r/66221/#comment281394>

    typo: configuartion



src/docs/user/saved-jobs.txt
Lines 296 (patched)
<https://reviews.apache.org/r/66221/#comment281397>

    I think we should explicitly state that MySQL, MSSQL,  Hsqldb, PostgreSQL, Oracle and
DB2 are supported since we only test these. Other RDBMSs might work but we should not confuse
the users.


- Szabolcs Vasas


On March 27, 2018, 11:48 a.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66221/
> -----------------------------------------------------------
> 
> (Updated March 27, 2018, 11:48 a.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3301
>     https://issues.apache.org/jira/browse/SQOOP-3301
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> This is the documentation for the metastore related patch implemented by Zach Berkowitz.
> 
> 
> Diffs
> -----
> 
>   src/docs/man/sqoop-job.txt 8be57402 
>   src/docs/user/metastore-purpose.txt 95c2d774 
>   src/docs/user/saved-jobs.txt 6885079f 
> 
> 
> Diff: https://reviews.apache.org/r/66221/diff/2/
> 
> 
> Testing
> -------
> 
> ant docs ran successfully
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message