sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anna Szonyi via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build for Sqoop to make it more developer friendly / open
Date Tue, 24 Apr 2018 14:23:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/
-----------------------------------------------------------

(Updated April 24, 2018, 2:23 p.m.)


Review request for Sqoop.


Changes
-------

changed per Szabi's comments and regenerated with --binary per Fero's issue.


Bugs: Sqoop-3052
    https://issues.apache.org/jira/browse/Sqoop-3052


Repository: sqoop-trunk


Description
-------

SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open


Diffs (updated)
-----

  .gitignore 68cbe28731e613607c208824443d1edf256d9c8a 
  COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5 
  build.gradle PRE-CREATION 
  config/checkstyle/checkstyle-java-header.txt PRE-CREATION 
  config/checkstyle/checkstyle-noframes.xsl PRE-CREATION 
  config/checkstyle/checkstyle.xml PRE-CREATION 
  gradle.properties PRE-CREATION 
  gradle/customUnixStartScript.txt PRE-CREATION 
  gradle/customWindowsStartScript.txt PRE-CREATION 
  gradle/sqoop-package.gradle PRE-CREATION 
  gradle/sqoop-version-gen.gradle PRE-CREATION 
  gradle/wrapper/gradle-wrapper.jar PRE-CREATION 
  gradle/wrapper/gradle-wrapper.properties PRE-CREATION 
  gradlew PRE-CREATION 
  gradlew.bat PRE-CREATION 
  settings.gradle PRE-CREATION 
  src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556 
  testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313 


Diff: https://reviews.apache.org/r/66067/diff/10/

Changes: https://reviews.apache.org/r/66067/diff/9-10/


Testing
-------

ran all new tasks, except for internal maven publishing

Notes:
- To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to
current tasks/artifacts.
- Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all
test results into a single report.
- Generated pom.xml now has correct dependencies/versions
- Script generation is currently hardcoded and not based on sqoop help, as previously - though
added the possiblity of hooking it in later


Thanks,

Anna Szonyi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message