sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <b...@apache.org>
Subject Re: Review Request 67086: SQOOP-3324 Document SQOOP-816: Sqoop add support for external Hive tables
Date Fri, 11 May 2018 13:46:08 GMT


> On May 11, 2018, 11:32 a.m., daniel voros wrote:
> > src/docs/user/hive.txt
> > Lines 115 (patched)
> > <https://reviews.apache.org/r/67086/diff/1/?file=2019903#file2019903line115>
> >
> >     nit: I'm sure we have this wrong elsewhere too, but I think we should say "switch"
or "option" instead of "flag" if it takes an argument.

+1 for using "option" here.


- Boglarka


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67086/#review202923
-----------------------------------------------------------


On May 11, 2018, 11:10 a.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67086/
> -----------------------------------------------------------
> 
> (Updated May 11, 2018, 11:10 a.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3324
>     https://issues.apache.org/jira/browse/SQOOP-3324
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> This is a missing documentation from Sqoop.
> 
> 
> Diffs
> -----
> 
>   src/docs/man/hive-args.txt 438c1dc4 
>   src/docs/user/hive-args.txt 75095641 
>   src/docs/user/hive.txt f8f7c27e 
> 
> 
> Diff: https://reviews.apache.org/r/67086/diff/1/
> 
> 
> Testing
> -------
> 
> ant docs completed successfully.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message