sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Teoh <chris.t...@gmail.com>
Subject Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer
Date Tue, 29 May 2018 08:05:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/
-----------------------------------------------------------

(Updated May 29, 2018, 8:05 a.m.)


Review request for Sqoop.


Changes
-------

Updated after some testing.


Bugs: SQOOP-3224
    https://issues.apache.org/jira/browse/SQOOP-3224


Repository: sqoop-trunk


Description
-------

Added --as-binaryfile and --buffersize to support FTP transfer mode switching.


Diffs (updated)
-----

  src/java/org/apache/sqoop/SqoopOptions.java d9984af3 
  src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java a5962ba4 
  src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION 
  src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21 
  src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java
PRE-CREATION 
  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java ea54b07f 
  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java PRE-CREATION

  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java PRE-CREATION

  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java 1f78384b

  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java 0b7b5b85

  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 7e975c7b 
  src/java/org/apache/sqoop/tool/BaseSqoopTool.java 783651a4 
  src/java/org/apache/sqoop/tool/ImportTool.java ee79d8b7 
  src/java/org/apache/sqoop/tool/MainframeImportTool.java 8883301d 
  src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb 
  src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java PRE-CREATION

  src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java 3547294f

  src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34 
  src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194 


Diff: https://reviews.apache.org/r/62492/diff/11/

Changes: https://reviews.apache.org/r/62492/diff/10-11/


Testing
-------

Unit tests.

Functional testing on mainframe.


Thanks,

Chris Teoh


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message