> On June 1, 2018, 3:01 p.m., Fero Szabo wrote:
> > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeFTPFileEntryParser.java
> > Line 54 (original), 66 (patched)
> > <https://reviews.apache.org/r/67407/diff/1/?file=2034240#file2034240line66>
> >
> > Since this is a constant, you could make it final and uppercase (this probably
applies to all the other constants in this file)
> >
> > private static final String MIGRATED_STRING = "Migrated";
Thanks for your review. I have refactored as requested. Can the other constants be refactored
as part of another jira? Last time I touched other code outside the scope of the patch, I
was told not to do that.
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67407/#review204185
-----------------------------------------------------------
On May 31, 2018, 11:25 p.m., Chris Teoh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67407/
> -----------------------------------------------------------
>
> (Updated May 31, 2018, 11:25 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Mainframe FTP needs to Include "Migrated" datasets when parsing the FTP list. Initially,
these were excluded out of the regular expression.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/mapreduce/mainframe/MainframeFTPFileEntryParser.java f0b87868
> src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeFTPFileEntryParser.java
eb0f8c00
>
>
> Diff: https://reviews.apache.org/r/67407/diff/1/
>
>
> Testing
> -------
>
> Unit testing.
>
>
> Thanks,
>
> Chris Teoh
>
>
|