sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Teoh <chris.t...@gmail.com>
Subject Re: Review Request 67407: SQOOP-3327: Mainframe FTP needs to Include "Migrated" datasets when parsing the FTP list
Date Fri, 01 Jun 2018 23:46:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67407/
-----------------------------------------------------------

(Updated June 1, 2018, 11:46 p.m.)


Review request for Sqoop.


Changes
-------

Refactored constant as part of feedback.


Repository: sqoop-trunk


Description
-------

Mainframe FTP needs to Include "Migrated" datasets when parsing the FTP list. Initially, these
were excluded out of the regular expression.


Diffs (updated)
-----

  src/java/org/apache/sqoop/avro/AvroUtil.java 57c20625 
  src/java/org/apache/sqoop/manager/ConnManager.java c80dd5d9 
  src/java/org/apache/sqoop/manager/CubridManager.java a75268f3 
  src/java/org/apache/sqoop/manager/Db2Manager.java c78946e6 
  src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java 70b9b43d 
  src/java/org/apache/sqoop/manager/MainframeManager.java 4e8be155 
  src/java/org/apache/sqoop/manager/MySQLManager.java 992c4615 
  src/java/org/apache/sqoop/manager/OracleManager.java cdc6c54c 
  src/java/org/apache/sqoop/manager/SQLServerManager.java b136087f 
  src/java/org/apache/sqoop/manager/SqlManager.java d82332ae 
  src/java/org/apache/sqoop/manager/oracle/OraOopConnManager.java 95eaacf3 
  src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 3b542102 
  src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 17c9ed39 
  src/java/org/apache/sqoop/mapreduce/JdbcCallExportJob.java be82aeda 
  src/java/org/apache/sqoop/mapreduce/JdbcExportJob.java e283548e 
  src/java/org/apache/sqoop/mapreduce/JdbcUpdateExportJob.java f901d378 
  src/java/org/apache/sqoop/mapreduce/JdbcUpsertExportJob.java 4db86da6 
  src/java/org/apache/sqoop/mapreduce/MergeJob.java c26a0901 
  src/java/org/apache/sqoop/mapreduce/MergeParquetReducer.java 5939b01d 
  src/java/org/apache/sqoop/mapreduce/ParquetImportMapper.java 62334f8a 
  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeFTPFileEntryParser.java f0b87868

  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 8ef30d38 
  src/java/org/apache/sqoop/mapreduce/parquet/ParquetConstants.java ae53a96b 
  src/java/org/apache/sqoop/mapreduce/parquet/ParquetExportJobConfigurator.java 8d7b87f6 
  src/java/org/apache/sqoop/mapreduce/parquet/ParquetImportJobConfigurator.java fa1bc7d1 
  src/java/org/apache/sqoop/mapreduce/parquet/ParquetJobConfiguratorFactory.java ed5103f1

  src/java/org/apache/sqoop/mapreduce/parquet/ParquetJobConfiguratorFactoryProvider.java 2286a520

  src/java/org/apache/sqoop/mapreduce/parquet/ParquetMergeJobConfigurator.java 67fdf660 
  src/java/org/apache/sqoop/mapreduce/parquet/kite/KiteMergeParquetReducer.java 7f21205e 
  src/java/org/apache/sqoop/mapreduce/parquet/kite/KiteParquetExportJobConfigurator.java ca02c7bd

  src/java/org/apache/sqoop/mapreduce/parquet/kite/KiteParquetExportMapper.java 25555d88 
  src/java/org/apache/sqoop/mapreduce/parquet/kite/KiteParquetImportJobConfigurator.java 87828d14

  src/java/org/apache/sqoop/mapreduce/parquet/kite/KiteParquetImportMapper.java 20adf6e4 
  src/java/org/apache/sqoop/mapreduce/parquet/kite/KiteParquetJobConfiguratorFactory.java
055e1166 
  src/java/org/apache/sqoop/mapreduce/parquet/kite/KiteParquetMergeJobConfigurator.java 9fecf282

  src/java/org/apache/sqoop/mapreduce/parquet/kite/KiteParquetUtils.java e68bba90 
  src/java/org/apache/sqoop/mapreduce/postgresql/PostgreSQLCopyExportJob.java ea2b064e 
  src/java/org/apache/sqoop/tool/BaseSqoopTool.java c62ee98c 
  src/java/org/apache/sqoop/tool/ImportTool.java 2c474b7e 
  src/java/org/apache/sqoop/tool/MergeTool.java 4c20f7d1 
  src/test/org/apache/sqoop/TestParquetImport.java 27d407aa 
  src/test/org/apache/sqoop/hive/TestHiveImport.java 436f0e51 
  src/test/org/apache/sqoop/mapreduce/TestJdbcExportJob.java 81ab6772 
  src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeFTPFileEntryParser.java eb0f8c00

  src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeImportJob.java be62efd0 


Diff: https://reviews.apache.org/r/67407/diff/2/

Changes: https://reviews.apache.org/r/67407/diff/1-2/


Testing
-------

Unit testing.


Thanks,

Chris Teoh


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message