sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fero Szabo via Review Board <nore...@reviews.apache.org>
Subject Review Request 67524: SQOOP-3333 Change default behavior of the MS SQL connector to non-resilient.
Date Mon, 11 Jun 2018 12:28:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67524/
-----------------------------------------------------------

Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.


Bugs: SQOOP-3333
    https://issues.apache.org/jira/browse/SQOOP-3333


Repository: sqoop-trunk


Description
-------

This change is about changing the default behavior of the MS SQL connectore from resilient
to non-resilient. I was aiming for the fewest possible modifications while also removed double
negation.

I've also changed the documentation of the non-resilient flag and added a note about the implicit
requirement of the feature (that the split-by column has to be unique and ordered in ascending
order). 

I plan to expand the documentation more in SQOOP-3332, as the (now named) resilient flag works
not just for export, but import as well.


Diffs
-----

  src/docs/user/connectors.txt 7c540718 
  src/java/org/apache/sqoop/manager/SQLServerManager.java b136087f 


Diff: https://reviews.apache.org/r/67524/diff/1/


Testing
-------

unit and 3rd party tests.
ant docs ran succesfully.
manual testing.


Thanks,

Fero Szabo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message