sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szabolcs Vasas <vasas.szabo...@gmail.com>
Subject Re: Review Request 67429: SQOOP-3331: Add mainframe integration test for GDG
Date Fri, 15 Jun 2018 08:14:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67429/#review204823
-----------------------------------------------------------



Thanks for fixing my findings, I have found a few more minor things.


src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java
Lines 31 (patched)
<https://reviews.apache.org/r/67429/#comment287561>

    Unused import, please remove the rest of them as well.



src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java
Lines 93 (patched)
<https://reviews.apache.org/r/67429/#comment287562>

    Unnecessary field.



src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java
Lines 96 (patched)
<https://reviews.apache.org/r/67429/#comment287563>

    Unnecessary method.


- Szabolcs Vasas


On June 15, 2018, 7:49 a.m., Chris Teoh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67429/
> -----------------------------------------------------------
> 
> (Updated June 15, 2018, 7:49 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Added simple test for GDG dataset. Fixed bug triggered by recent Parquet patch.
> 
> 
> Diffs
> -----
> 
>   build.xml a85705fa 
>   src/java/org/apache/sqoop/manager/MainframeManager.java 4e8be155 
>   src/scripts/thirdpartytest/docker-compose/sqoop-thirdpartytest-db-services.yml 2f4a07f6

>   src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/67429/diff/5/
> 
> 
> Testing
> -------
> 
> Running the integration and unit test on a patched version of trunk.
> 
> 
> Thanks,
> 
> Chris Teoh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message