-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67629/#review204921
-----------------------------------------------------------
Ship it!
Ship it! (Maybe you could also consider dropping the Argument class, now that we're using
maps.)
- daniel voros
On June 18, 2018, 12:06 p.m., Fero Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67629/
> -----------------------------------------------------------
>
> (Updated June 18, 2018, 12:06 p.m.)
>
>
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3334
> https://issues.apache.org/jira/browse/SQOOP-3334
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Changed the implementation so that it uses maps instead of lists.
>
>
> Diffs
> -----
>
> src/test/org/apache/sqoop/testutil/ArgumentArrayBuilder.java 00ce4fe8
> src/test/org/apache/sqoop/testutil/TestArgumentArrayBuilder.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67629/diff/1/
>
>
> Testing
> -------
>
> Added 2 new unit tests.
> Ran 3rdparty and unit tests.
>
>
> Thanks,
>
> Fero Szabo
>
>
|