sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fero Szabo via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 67629: SQOOP-3334 Improve ArgumentArrayBuilder, so arguments are replaceable
Date Fri, 22 Jun 2018 14:08:31 GMT 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67629/
-----------------------------------------------------------

(Updated June 22, 2018, 2:08 p.m.)


Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.


Bugs: SQOOP-3334
    https://issues.apache.org/jira/browse/SQOOP-3334


Repository: sqoop-trunk


Description
-------

Changed the implementation so that it uses maps instead of lists.


Diffs (updated)
-----

  src/test/org/apache/sqoop/testutil/ArgumentArrayBuilder.java 00ce4fe8 
  src/test/org/apache/sqoop/testutil/TestArgumentArrayBuilder.java PRE-CREATION 


Diff: https://reviews.apache.org/r/67629/diff/2/

Changes: https://reviews.apache.org/r/67629/diff/1-2/


Testing
-------

Added 2 new unit tests.
Ran 3rdparty and unit tests.


Thanks,

Fero Szabo
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message