sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szabolcs Vasas <vasas.szabo...@gmail.com>
Subject Re: Review Request 67629: SQOOP-3334 Improve ArgumentArrayBuilder, so arguments are replaceable
Date Mon, 25 Jun 2018 12:33:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67629/#review205280
-----------------------------------------------------------



Hi Feró,

Thank you for submitting this improvement and for adding the test case, I have left only one
small comment.


src/test/org/apache/sqoop/testutil/TestArgumentArrayBuilder.java
Lines 35 (patched)
<https://reviews.apache.org/r/67629/#comment288216>

    Is there a reason we don't use org.junit.Assert#assertArrayEquals(java.lang.Object[],
java.lang.Object[]) here?


- Szabolcs Vasas


On June 22, 2018, 2:08 p.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67629/
> -----------------------------------------------------------
> 
> (Updated June 22, 2018, 2:08 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3334
>     https://issues.apache.org/jira/browse/SQOOP-3334
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Changed the implementation so that it uses maps instead of lists.
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/testutil/ArgumentArrayBuilder.java 00ce4fe8 
>   src/test/org/apache/sqoop/testutil/TestArgumentArrayBuilder.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67629/diff/2/
> 
> 
> Testing
> -------
> 
> Added 2 new unit tests.
> Ran 3rdparty and unit tests.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message