sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fero Szabo via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 67675: SQOOP-3332 Extend Documentation of --resilient flag and add warning message when detected
Date Thu, 28 Jun 2018 12:29:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67675/
-----------------------------------------------------------

(Updated June 28, 2018, 12:29 p.m.)


Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.


Changes
-------

small correction to make the implicit requirement a little bit clearer.


Bugs: SQOOP-3332
    https://issues.apache.org/jira/browse/SQOOP-3332


Repository: sqoop-trunk


Description
-------

This is the documentation part of SQOOP-3333.


Diffs (updated)
-----

  src/docs/user/connectors.txt f1c7aebe 
  src/java/org/apache/sqoop/manager/SQLServerManager.java c98ad2db 
  src/java/org/apache/sqoop/manager/SqlServerManagerContextConfigurator.java cf58f631 
  src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerImportTest.java fc1c4895 


Diff: https://reviews.apache.org/r/67675/diff/3/

Changes: https://reviews.apache.org/r/67675/diff/2-3/


Testing
-------

Unit tests, 3rdparty tests, ant docs.

I've also investigated how export and import works: 

Import has it's retry mechanism in org.apache.sqoop.mapreduce.db.SQLServerDBRecordReader#nextKeyValue
In case of error, it re-calculates the db query, thus the implicit requirements

Export has it's retry loop in org.apache.sqoop.mapreduce.SQLServerAsyncDBExecThread#write
It doesn't recalculate the query, thus is a lot safer.


Thanks,

Fero Szabo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message