From dev-return-36222-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Mon Jun 25 15:17:09 2018 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 38582182D9 for ; Mon, 25 Jun 2018 15:17:09 +0000 (UTC) Received: (qmail 78437 invoked by uid 500); 25 Jun 2018 15:17:09 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 78396 invoked by uid 500); 25 Jun 2018 15:17:09 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 78376 invoked by uid 500); 25 Jun 2018 15:17:08 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 78373 invoked by uid 99); 25 Jun 2018 15:17:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jun 2018 15:17:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 08664C01AD; Mon, 25 Jun 2018 15:17:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.7 X-Spam-Level: X-Spam-Status: No, score=0.7 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 3ZBspadZsIUl; Mon, 25 Jun 2018 15:17:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 64EE95F4A3; Mon, 25 Jun 2018 15:17:06 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E7952E00B8; Mon, 25 Jun 2018 15:17:05 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B0E63C40360; Mon, 25 Jun 2018 15:17:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9117724223895534945==" MIME-Version: 1.0 Subject: Re: Review Request 67675: SQOOP-3332 Extend Documentation of --resilient flag and add warning message when detected From: Fero Szabo via Review Board To: Szabolcs Vasas , daniel voros , Boglarka Egyed Cc: Fero Szabo , Sqoop Date: Mon, 25 Jun 2018 15:17:05 -0000 Message-ID: <20180625151705.19789.3864@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Fero Szabo X-ReviewGroup: Sqoop X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67675/ X-Sender: Fero Szabo References: <20180622102228.48009.63805@reviews-vm2.apache.org> In-Reply-To: <20180622102228.48009.63805@reviews-vm2.apache.org> Reply-To: Fero Szabo X-ReviewRequest-Repository: sqoop-trunk --===============9117724223895534945== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67675/ ----------------------------------------------------------- (Updated June 25, 2018, 3:17 p.m.) Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas. Changes ------- Added a fix for a bug in SQLServerManagerImportTest, introduced in SQOOP-3333: while the constructor of the testclass is invoked for every test again and a again, the configuration object are only instatiated once. Thus 5 tests were reusing the same configuration references, polluting the builders. (in the end the builder contained the following tool options: --table-hints NOLOCK --table-hints NOLOCK,NOWAIT --non-resilient --resilient) This fix avoids that by creating a new copy of the builder, each time the constructor is invoked Bugs: SQOOP-3332 https://issues.apache.org/jira/browse/SQOOP-3332 Repository: sqoop-trunk Description ------- This is the documentation part of SQOOP-3333. Diffs (updated) ----- src/docs/user/connectors.txt f1c7aebe src/java/org/apache/sqoop/manager/SQLServerManager.java c98ad2db src/java/org/apache/sqoop/manager/SqlServerManagerContextConfigurator.java cf58f631 src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerImportTest.java fc1c4895 Diff: https://reviews.apache.org/r/67675/diff/2/ Changes: https://reviews.apache.org/r/67675/diff/1-2/ Testing ------- Unit tests, 3rdparty tests, ant docs. I've also investigated how export and import works: Import has it's retry mechanism in org.apache.sqoop.mapreduce.db.SQLServerDBRecordReader#nextKeyValue In case of error, it re-calculates the db query, thus the implicit requirements Export has it's retry loop in org.apache.sqoop.mapreduce.SQLServerAsyncDBExecThread#write It doesn't recalculate the query, thus is a lot safer. Thanks, Fero Szabo --===============9117724223895534945==--