-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67675/
-----------------------------------------------------------

(Updated June 25, 2018, 3:17 p.m.)


Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.


Changes
-------

Added a fix for a bug in SQLServerManagerImportTest, introduced in SQOOP-3333: while the constructor of the testclass is invoked for every test again and a again, the configuration object are only instatiated once. Thus 5 tests were reusing the same configuration references, polluting the builders. 
(in the end the builder contained the following tool options: --table-hints NOLOCK --table-hints NOLOCK,NOWAIT --non-resilient --resilient)

This fix avoids that by creating a new copy of the builder, each time the constructor is invoked


Bugs: SQOOP-3332
    https://issues.apache.org/jira/browse/SQOOP-3332


Repository: sqoop-trunk


Description
-------

This is the documentation part of SQOOP-3333.


Diffs (updated)
-----

  src/docs/user/connectors.txt f1c7aebe 
  src/java/org/apache/sqoop/manager/SQLServerManager.java c98ad2db 
  src/java/org/apache/sqoop/manager/SqlServerManagerContextConfigurator.java cf58f631 
  src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerImportTest.java fc1c4895 


Diff: https://reviews.apache.org/r/67675/diff/2/

Changes: https://reviews.apache.org/r/67675/diff/1-2/


Testing
-------

Unit tests, 3rdparty tests, ant docs.

I've also investigated how export and import works: 

Import has it's retry mechanism in org.apache.sqoop.mapreduce.db.SQLServerDBRecordReader#nextKeyValue
In case of error, it re-calculates the db query, thus the implicit requirements

Export has it's retry loop in org.apache.sqoop.mapreduce.SQLServerAsyncDBExecThread#write
It doesn't recalculate the query, thus is a lot safer.


Thanks,

Fero Szabo