sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Teoh <chris.t...@gmail.com>
Subject Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer
Date Tue, 03 Jul 2018 06:21:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/
-----------------------------------------------------------

(Updated July 3, 2018, 4:21 p.m.)


Review request for Sqoop.


Changes
-------

As per feedback.


Bugs: SQOOP-3224
    https://issues.apache.org/jira/browse/SQOOP-3224


Repository: sqoop-trunk


Description
-------

Added --as-binaryfile and --buffersize to support FTP transfer mode switching.


Diffs (updated)
-----

  build.xml 0ae729bc 
  src/docs/user/import-mainframe.txt abeb7cde 
  src/java/org/apache/sqoop/SqoopOptions.java 3a19aeac 
  src/java/org/apache/sqoop/mapreduce/ByteKeyOutputFormat.java PRE-CREATION 
  src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 349ca8d8 
  src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION 
  src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21 
  src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java
PRE-CREATION 
  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java ea54b07f 
  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java PRE-CREATION

  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java PRE-CREATION

  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java 1f78384b

  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java 0b7b5b85

  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 8ef30d38 
  src/java/org/apache/sqoop/tool/BaseSqoopTool.java 8d318327 
  src/java/org/apache/sqoop/tool/ImportTool.java 25c3f703 
  src/java/org/apache/sqoop/tool/MainframeImportTool.java 8883301d 
  src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb 
  src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java 041dfb78 
  src/test/org/apache/sqoop/manager/mainframe/MainframeTestUtil.java f28ff36c 
  src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java PRE-CREATION

  src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java 3547294f

  src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34 
  src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194 


Diff: https://reviews.apache.org/r/62492/diff/18/

Changes: https://reviews.apache.org/r/62492/diff/17-18/


Testing
-------

Unit tests.

Functional testing on mainframe.


Thanks,

Chris Teoh


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message