sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sandish Kumar HN <sanysand...@gmail.com>
Subject Re: Review Request 61615: Add Sqoop1 (import + --incremental + --check-column) support for functions/expressions
Date Thu, 05 Jul 2018 08:58:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61615/#review205737
-----------------------------------------------------------


Ship it!




- Sandish Kumar HN


On July 5, 2018, 8:56 a.m., Eric Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61615/
> -----------------------------------------------------------
> 
> (Updated July 5, 2018, 8:56 a.m.)
> 
> 
> Review request for Sqoop and Boglarka Egyed.
> 
> 
> Bugs: SQOOP-3186
>     https://issues.apache.org/jira/browse/SQOOP-3186
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Add Sqoop1 (import + --incremental + --check-column) support for functions/expressions,
for example:
> Example
> sqoop import \
> --connect $MYCONN --username $MYUSER --password $MYPSWD \
> --table T1 --target-dir /path/directory --merge-key C1 \
> --incremental lastmodified  --last-value '2017-01-01 00:00:00.0' \
> --check-column nvl(C4,to_date('2017-01-01 00:00:00')
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/SqoopOptions.java 3a19aeac 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 8d318327 
>   src/java/org/apache/sqoop/tool/ImportTool.java 25c3f703 
>   src/test/org/apache/sqoop/mapreduce/TestImportJob.java 941acb6d 
> 
> 
> Diff: https://reviews.apache.org/r/61615/diff/2/
> 
> 
> Testing
> -------
> 
> Manual testing, still working on adding test cases.
> 
> This is first iteration, so code still need to be refined. I will update to latest trunk
once suggestions are made.
> 
> 
> Thanks,
> 
> Eric Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message