sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fero Szabo via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 67926: Document Parquet support
Date Mon, 16 Jul 2018 12:24:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67926/#review206097
-----------------------------------------------------------



LGTM.

Perhaps you could consider another example with the compression codecs specified. Is my understanding
correct, that the compression codec has to come from an option, and not from a system property
or the site.xml?


src/docs/user/import.txt
Lines 481 (patched)
<https://reviews.apache.org/r/67926/#comment289025>

    Perhaps it would make sense to give an example with a hs2 url and a compression codec.


- Fero Szabo


On July 16, 2018, 12:15 p.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67926/
> -----------------------------------------------------------
> 
> (Updated July 16, 2018, 12:15 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3338
>     https://issues.apache.org/jira/browse/SQOOP-3338
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Documenting Parquet support and covering the changes brought in by SQOOP-3313.
> 
> 
> Diffs
> -----
> 
>   src/docs/user/hive-args.txt 8af9a1c51 
>   src/docs/user/hive-notes.txt deee27021 
>   src/docs/user/import.txt 2d074f492 
> 
> 
> Diff: https://reviews.apache.org/r/67926/diff/1/
> 
> 
> Testing
> -------
> 
> ant docs is executed successfully.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message