sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <b...@apache.org>
Subject Review Request 68000: SQOOP-3347: Make verify() more generic in AvroTestUtils
Date Fri, 20 Jul 2018 13:47:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68000/
-----------------------------------------------------------

Review request for Sqoop, daniel voros, Fero Szabo, and Szabolcs Vasas.


Bugs: SQOOP-3347
    https://issues.apache.org/jira/browse/SQOOP-3347


Repository: sqoop-trunk


Description
-------

Extracting decimal conversion logic from verify() method of AvroTestUtils class.


Diffs
-----

  src/test/org/apache/sqoop/importjob/avro/AvroImportForNumericTypesTest.java e04caf7c7c1fba24a47858c609a00ecac9f71cc5

  src/test/org/apache/sqoop/manager/hsqldb/TestHsqldbAvroPadding.java 7e42bf1e3242acc26ae196986daa96a9160196ed

  src/test/org/apache/sqoop/testutil/AvroTestUtils.java 75940bf1fe77ba4655d88c3c0f415c548201daf9



Diff: https://reviews.apache.org/r/68000/diff/1/


Testing
-------

Ran unit and 3rd party tests successfully.


Thanks,

Boglarka Egyed


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message