sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fero Szabo via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 68254: Change MainframeImportTool to refer to MainframeManager class directly
Date Thu, 09 Aug 2018 13:33:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68254/#review207024
-----------------------------------------------------------


Ship it!




Ship It!

- Fero Szabo


On Aug. 7, 2018, 9:33 a.m., Nguyen Truong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68254/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2018, 9:33 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3357
>     https://issues.apache.org/jira/browse/SQOOP-3357
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> MainframeImportTool used to refer to the MainframeManager with a string. I changed the
string to a MainframeManager class reference.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/tool/MainframeImportTool.java 8883301d 
>   src/test/org/apache/sqoop/manager/TestMainframeManager.java 97e48e88 
> 
> 
> Diff: https://reviews.apache.org/r/68254/diff/1/
> 
> 
> Testing
> -------
> 
> I ran ant test and did not add any more test case because my change was already covered.
> 
> 
> Thanks,
> 
> Nguyen Truong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message