> On Aug. 15, 2018, 9:54 a.m., Szabolcs Vasas wrote:
> > Hi Nguyen,
> >
> > Thank you for adding the new test case, this is exactly what I was thinking of.
> > I have left some minor formatting findings please fix those and we can commit it.
> >
> > Thanks,
> > Szabolcs
Thank you for your review, Szabolcs.
I am sending a new review request soon.
Best,
Nguyen
- Nguyen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68316/#review207314
-----------------------------------------------------------
On Aug. 14, 2018, 12:53 p.m., Nguyen Truong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68316/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 12:53 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3362
> https://issues.apache.org/jira/browse/SQOOP-3362
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> The method was currently returning the hash of data chunk object. I implemented the toString()
methods inside the subclasses of OraOopOracleDataChunk.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/manager/oracle/OraOopDBInputSplit.java 948bdbb73
> src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunk.java eb67fd2e4
> src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java 20b39eea0
> src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java 59889b82b
> src/test/org/apache/sqoop/manager/oracle/TestOraOopDBInputSplitGetDebugDetails.java
PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68316/diff/3/
>
>
> Testing
> -------
>
> No test case is added because the change has already covered.
>
>
> Thanks,
>
> Nguyen Truong
>
>
|