sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nguyen Truong <nguyentruon...@gmail.com>
Subject Re: Review Request 68316: Fix toString() methods of OraOopOracleDataChunk
Date Thu, 16 Aug 2018 10:00:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68316/
-----------------------------------------------------------

(Updated Aug. 16, 2018, 10 a.m.)


Review request for Sqoop.


Summary (updated)
-----------------

Fix toString() methods of OraOopOracleDataChunk


Bugs: SQOOP-3362
    https://issues.apache.org/jira/browse/SQOOP-3362


Repository: sqoop-trunk


Description
-------

The method was currently returning the hash of data chunk object. I implemented the toString()
methods inside the subclasses of OraOopOracleDataChunk.


Diffs
-----

  src/java/org/apache/sqoop/manager/oracle/OraOopDBInputSplit.java 948bdbb73 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunk.java eb67fd2e4 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java 20b39eea0 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java 59889b82b 
  src/test/org/apache/sqoop/manager/oracle/TestOraOopDBInputSplitGetDebugDetails.java PRE-CREATION



Diff: https://reviews.apache.org/r/68316/diff/4/


Testing
-------

A test case is added named TestOraOopDBInputSplitGetDebugDetails.


Thanks,

Nguyen Truong


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message