sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szabolcs Vasas <vasas.szabo...@gmail.com>
Subject Review Request 68382: Upgrade Gradle version to 4.9
Date Thu, 16 Aug 2018 14:37:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68382/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-3364
    https://issues.apache.org/jira/browse/SQOOP-3364


Repository: sqoop-trunk


Description
-------

Apart from the Gradle version bump the change contains the following:
- html.destination type is modified to file to avoid deprecation warning
- the task wrapper is replaced with wrapper {} to avoid deprecation warning
- enableFeaturePreview('STABLE_PUBLISHING') is added to settings.gradle to avoid deprecation
warning. This is a change I could not test since we cannot publish to maven repo now. However
in a case of a future release we should test it as described here: https://docs.gradle.org/4.9/userguide/publishing_maven.html#publishing_maven:deferred_configuration
- The HBase test cases failed at first because the regionserver web ui was not able to start
up most probably because of a bad version of a Jetty class on the classpath. However we do
not need the regionserver web ui for the Sqoop tests so instead of playing around with libraries
I disabled it just like we have already disabled the master web ui.


Diffs
-----

  build.gradle 709172cc0 
  gradle/wrapper/gradle-wrapper.jar 99340b4ad18d3c7e764794d300ffd35017036793 
  gradle/wrapper/gradle-wrapper.properties 90a06cec7 
  settings.gradle 7d64af500 
  src/test/org/apache/sqoop/hbase/HBaseTestCase.java 87fce34a8 


Diff: https://reviews.apache.org/r/68382/diff/1/


Testing
-------

Executed unit and third party test suite successfully.


Thanks,

Szabolcs Vasas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message