sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nguyen Truong <nguyentruon...@gmail.com>
Subject Re: Review Request 68470: SQOOP-3366 Improve unit tests to be able to execute them in a single JVM
Date Fri, 24 Aug 2018 08:07:43 GMT


> On Aug. 23, 2018, 4:33 p.m., Szabolcs Vasas wrote:
> > Hi Nguyen,
> > 
> > Thanks for submitting this patch!
> > 
> > I have applied it, disabled the kerberized unit tests (TestKerberosAuthenticator,
TestHiveMiniCluster, TestHiveServer2TextImport) and ./gradlew test ran successfully with forkEvery
parameter set to 0.
> > The test execution time has reduced to 8.5 minutes from ~20 minutes!

Hi Szabolcs,

Thank you for commenting how you ran the tests. I should have showed how to test the code.


- Nguyen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68470/#review207818
-----------------------------------------------------------


On Aug. 23, 2018, 3:54 p.m., Nguyen Truong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68470/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2018, 3:54 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3366
>     https://issues.apache.org/jira/browse/SQOOP-3366
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Fix the unit tests which changed the state of the JVM so that other tests will not be
affected when they are run on a single JVM.
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/TestIncrementalImport.java e1faf351f 
>   src/test/org/apache/sqoop/TestSqoopOptions.java d0591ad0d 
>   src/test/org/apache/sqoop/metastore/TestMetastoreConfigurationParameters.java 0f1eb890b

>   src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java 1730698e8 
>   src/test/org/apache/sqoop/testutil/HsqldbTestServer.java c63a8f2dc 
>   src/test/org/apache/sqoop/tool/TestMainframeImportTool.java c2edc5347 
> 
> 
> Diff: https://reviews.apache.org/r/68470/diff/3/
> 
> 
> Testing
> -------
> 
> No test has been added.
> 
> 
> Thanks,
> 
> Nguyen Truong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message