sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szabolcs Vasas <vasas.szabo...@gmail.com>
Subject Re: Review Request 68536: SQOOP-3368: Add fail-fast scenarios to S3 incremental import use cases without --temporary-rootdir option
Date Thu, 30 Aug 2018 11:15:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68536/#review208123
-----------------------------------------------------------


Ship it!




Hi Bogi,

Thanks for improving the patch, I have ran the tests, everything looks good, let's ship it!

- Szabolcs Vasas


On Aug. 30, 2018, 9:59 a.m., Boglarka Egyed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68536/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2018, 9:59 a.m.)
> 
> 
> Review request for Sqoop, daniel voros, Fero Szabo, Nguyen Truong, and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3368
>     https://issues.apache.org/jira/browse/SQOOP-3368
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> The current implementation of Sqoop handles HDFS as a default filesystem, i.e. it creates
temporary directories on HDFS in case of incremental append or merge imports. To make these
incremental import use cases work with S3 the user needs to set the --temporary-rootdir to
an S3 location properly.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/tool/ImportTool.java 139733732d2a28d171568b9118c98a47a3d2fc50

>   src/test/org/apache/sqoop/tool/TestS3IncrementalImportOptionValidations.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/68536/diff/3/
> 
> 
> Testing
> -------
> 
> ant clean test
> ./gradlew test -Ds3.bucket.url=<bucket-url> -Ds3.generator.command=<credential-generator-command>
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message