sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dae Myung Kang <chars...@gmail.com>
Subject Re: Review Request 68717: [sqoop-2639] supporting mysql export with specific encoding with --mysql-charset option
Date Fri, 14 Sep 2018 15:54:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68717/
-----------------------------------------------------------

(Updated Sept. 14, 2018, 3:54 p.m.)


Review request for Sqoop.


Changes
-------

change example


Bugs: sqoop-2639
    https://issues.apache.org/jira/browse/sqoop-2639


Repository: sqoop-trunk


Description (updated)
-------

sqmanually test with testing senario.

It will just change mysqlCharset by commandline option

when not given --mysql-charset 

select query returned 

```
FX????
```

given --mysql-charset=UTF-8
```
FX????
```


Diffs
-----

  src/java/org/apache/sqoop/SqoopOptions.java f06872f9 
  src/java/org/apache/sqoop/manager/MySQLUtils.java b005c793 
  src/java/org/apache/sqoop/mapreduce/MySQLExportJob.java e17f3df8 
  src/java/org/apache/sqoop/mapreduce/MySQLExportMapper.java bb751ee6 
  src/java/org/apache/sqoop/tool/BaseSqoopTool.java 955d3a65 
  src/java/org/apache/sqoop/tool/ExportTool.java 060f2c07 


Diff: https://reviews.apache.org/r/68717/diff/1/


Testing
-------

manually test, this is only change commandline cli


Thanks,

Dae Myung Kang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message