sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Teoh <chris.t...@gmail.com>
Subject Re: Review Request 62523: SQOOP-3237: Mainframe FTP transfer option to insert custom FTP commands prior to transfer
Date Wed, 31 Oct 2018 05:41:11 GMT


> On Oct. 19, 2018, 12:06 a.m., Szabolcs Vasas wrote:
> > src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java
> > Lines 223 (patched)
> > <https://reviews.apache.org/r/62523/diff/6/?file=2079210#file2079210line223>
> >
> >     Just a question here: do we want to do something with the reply strings?
> >     I case one of the commands cause an error we do not throw exception here which
could be fine but I think we need to document it.

At the moment, we only log the reply strings. Yes, I can add it into the documentation.


> On Oct. 19, 2018, 12:06 a.m., Szabolcs Vasas wrote:
> > src/test/org/apache/sqoop/tool/TestMainframeImportTool.java
> > Lines 241 (patched)
> > <https://reviews.apache.org/r/62523/diff/6/?file=2079211#file2079211line241>
> >
> >     You should use the assert methods in org.junit.Assert instead of the assert
statement.
> >     Please fix all occurrences.

Do you also want me to fix occurrences in this class not related to this change?


- Chris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62523/#review209738
-----------------------------------------------------------


On Oct. 31, 2018, 4:40 p.m., Chris Teoh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62523/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2018, 4:40 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3237
>     https://issues.apache.org/jira/browse/SQOOP-3237
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Added --ftpcmds command to allow comma separated list of FTP commands to send.
> 
> 
> Diffs
> -----
> 
>   src/docs/user/import-mainframe.txt 3ecfb7e4 
>   src/java/org/apache/sqoop/SqoopOptions.java f06872f9 
>   src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java 9842daa6

>   src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 90dc2ddd 
>   src/java/org/apache/sqoop/tool/MainframeImportTool.java fbc8c3db 
>   src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java e7c48a6b 
>   src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 00e57bd0 
>   src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 0714bdcf 
> 
> 
> Diff: https://reviews.apache.org/r/62523/diff/7/
> 
> 
> Testing
> -------
> 
> Unit tests.
> 
> 
> File Attachments
> ----------------
> 
> SQOOP-3237-1.patch
>   https://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
> 
> 
> Thanks,
> 
> Chris Teoh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message