sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <b...@apache.org>
Subject Re: Review Request 69199: Create tests for SQOOP-2949, quote escaping in split-by
Date Wed, 31 Oct 2018 15:13:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69199/#review210223
-----------------------------------------------------------


Ship it!




Hi Fero,

Thanks for this fix! I ran unit tests successfully with your patch. Change LGTM.

Cheers,
Bogi

- Boglarka Egyed


On Oct. 31, 2018, 1:51 p.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69199/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2018, 1:51 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3400
>     https://issues.apache.org/jira/browse/SQOOP-3400
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Integration tests for SQOOP-2949.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java 22bbfe68 
>   src/test/org/apache/sqoop/importjob/SplitByImportTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/configuration/GenericImportJobSplitByTestConfiguration.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69199/diff/6/
> 
> 
> Testing
> -------
> 
> This is the testing part for a fix that lacked testing. 
> gradle test and gradle 3rdpartytests.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message