sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <b...@apache.org>
Subject Re: Review Request 62523: SQOOP-3237: Mainframe FTP transfer option to insert custom FTP commands prior to transfer
Date Thu, 08 Nov 2018 10:34:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62523/#review210413
-----------------------------------------------------------



Hi Chris,

Many thanks for your continued efforts on Mainframe side!

I took a look at your patch and found a bug, please find it below. MainframeManagerImportTest
failed for me with the following error message, I believe the root cause is the bug you introduced
with the latest version of your patch:

ERROR - org.apache.sqoop.tool.ImportTool.run(ImportTool.java:635)] Import failed: The value
of property mainframe.ftp.commands must not be null

Could you please take a look?

Thanks,
Bogi


src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java
Lines 86 (patched)
<https://reviews.apache.org/r/62523/#comment295058>

    Shouldn't this condition be negated? StringUtils.isBalnk will be true if the character
sequence is null, empty or whitespace. I'm wondering how TestMainframeImportTool could pass
with your patch.



src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java
Lines 383-393 (patched)
<https://reviews.apache.org/r/62523/#comment295059>

    These configurations could be extracted to a separate method having a self-explanatory
name.


- Boglarka Egyed


On Oct. 31, 2018, 5:40 a.m., Chris Teoh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62523/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2018, 5:40 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3237
>     https://issues.apache.org/jira/browse/SQOOP-3237
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Added --ftpcmds command to allow comma separated list of FTP commands to send.
> 
> 
> Diffs
> -----
> 
>   src/docs/user/import-mainframe.txt 3ecfb7e4 
>   src/java/org/apache/sqoop/SqoopOptions.java f06872f9 
>   src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java 9842daa6

>   src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 90dc2ddd 
>   src/java/org/apache/sqoop/tool/MainframeImportTool.java fbc8c3db 
>   src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java e7c48a6b 
>   src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 00e57bd0 
>   src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 0714bdcf 
> 
> 
> Diff: https://reviews.apache.org/r/62523/diff/8/
> 
> 
> Testing
> -------
> 
> Unit tests.
> 
> 
> File Attachments
> ----------------
> 
> SQOOP-3237-1.patch
>   https://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch
> 
> 
> Thanks,
> 
> Chris Teoh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message