sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fero Szabo via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis
Date Wed, 21 Nov 2018 09:07:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/
-----------------------------------------------------------

(Updated Nov. 21, 2018, 9:07 a.m.)


Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.


Changes
-------

Refactored test class names to the same as used in the categorization


Bugs: SQOOP-3405
    https://issues.apache.org/jira/browse/SQOOP-3405


Repository: sqoop-trunk


Description
-------

Breaking up the parameterized test classes into a per database basis. Provides better readability,
needed for proper test categorization (and thus, for travis integration).


Diffs (updated)
-----

  src/java/org/apache/sqoop/hive/HiveTypes.java 554a03608 
  src/java/org/apache/sqoop/hive/TableDefWriter.java b21dfe534 
  src/test/org/apache/sqoop/hive/TestHiveServer2ParquetImport.java 8cfd776d5 


Diff: https://reviews.apache.org/r/69407/diff/2/

Changes: https://reviews.apache.org/r/69407/diff/1-2/


Testing
-------

unit and 3rd party tests.


Thanks,

Fero Szabo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message