sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fero Szabo via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis
Date Wed, 21 Nov 2018 10:20:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/
-----------------------------------------------------------

(Updated Nov. 21, 2018, 10:20 a.m.)


Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.


Bugs: SQOOP-3405
    https://issues.apache.org/jira/browse/SQOOP-3405


Repository: sqoop-trunk


Description
-------

Breaking up the parameterized test classes into a per database basis. Provides better readability,
needed for proper test categorization (and thus, for travis integration).


Diffs (updated)
-----

  src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cbe 
  src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbbd 
  src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java
4ad7defe 
  src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java fbcbdebe

  src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION

  src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java PRE-CREATION

  src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java PRE-CREATION

  src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java PRE-CREATION

  src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION 
  src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION

  src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION

  src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 22567162 
  src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd01468 


Diff: https://reviews.apache.org/r/69407/diff/5/

Changes: https://reviews.apache.org/r/69407/diff/4-5/


Testing
-------

unit and 3rd party tests.


Thanks,

Fero Szabo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message